feat: add validation of resolution values #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozsefdamokos
approved these changes
Jan 6, 2026
vintagesucks
approved these changes
Jan 6, 2026
ennasus4sun
approved these changes
Jan 7, 2026
...n/swag-migration-error-resolution-field/swag-migration-error-resolution-field-scalar.spec.js
Outdated
Show resolved
Hide resolved
larskemper
force-pushed
the
feat/add-validation-of-resolution-values
branch
from
f73931a to
ec3f5da
Compare
larskemper
changed the base branch from
feature/migration-logging-refactor
to
refactor/filter-optional-database-field
larskemper
requested review from
a team,
MalteJanz,
ennasus4sun and
vintagesucks
and removed request for
a team,
DennisGarding and
MalteJanz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same validation strategy we use to flag bad field values during error resolution to the values the user propose as fixes. Also for JSON inputs like cart prices, show users concrete example values they can adapt.